Re: Linux Kernel Regression: HAPS quirk breaks PCIe on i.MX6QP

From: Lukas Wunner
Date: Fri Feb 01 2019 - 03:59:12 EST


On Thu, Jan 31, 2019 at 11:46:23PM +0000, Thinh Nguyen wrote:
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -629,6 +629,9 @@ static void quirk_synopsys_haps(struct pci_dev *pdev)
> {
> u32 class = pdev->class;
>
> + if (class != PCI_CLASS_SERIAL_USB_XHCI)
> + return;
> +
> switch (pdev->device) {
> case PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3:
> case PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI:

Please use DECLARE_PCI_FIXUP_CLASS_HEADER() instead.

Thanks,

Lukas