Re: [PATCH] input_event: Provide override for sparc64

From: Arnd Bergmann
Date: Tue Jan 15 2019 - 16:19:47 EST


On Sat, Dec 29, 2018 at 7:35 PM Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote:

> struct timeval time;
> #define input_event_sec time.tv_sec
> #define input_event_usec time.tv_usec
> #else
> __kernel_ulong_t __sec;
> +#ifdef CONFIG_SPARC64
> + unsigned int __usec;
> +#else
> __kernel_ulong_t __usec;
> +#endif
> #define input_event_sec __sec
> #define input_event_usec __usec
> #endif

Sorry for not having looked at this earlier, I just realized that this
is a mistake
in user space: uapi headers are not allowed to reference CONFIG_* symbols,
since the headers are supposed to be configuration independent and the
CONFIG_* namespace might clash with user space identifiers.

The correct check appears to be

#if defined(__sparc__) && defined(__arch64__)

Arnd