Re: [PATCH 1/2] fuse: Fix race in fuse_writepage_in_flight()

From: Miklos Szeredi
Date: Tue Jan 15 2019 - 10:37:33 EST


On Thu, Jan 10, 2019 at 12:03 PM Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> wrote:
>
> On 10.01.2019 14:00, Miklos Szeredi wrote:
> > On Thu, Jan 10, 2019 at 11:48 AM Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> wrote:
> >>
> >> Hi, Miklos,
> >>
> >> any comments about this?
> >
> > Is there a reproducer? ISTR that fsx-linux with mmaps enabled was
> > good for stressing the writeback_cache code.
>
> There is no a reproducer, since I found that by eyes during preparation of another patchset.

That's good. It would even better to have a reproducer, but it
doesn't look easy...

Completely redid this and reordered the patchset so this change is
made before the locking changes actually introduce the bug. See
fuse.git#for-next.

Thanks,
Miklos