Re: [PATCH v1 1/2] Documentation/filesystems: add binderfs

From: Christian Brauner
Date: Tue Jan 15 2019 - 03:59:45 EST


On Mon, Jan 14, 2019 at 05:24:01PM -0700, Jonathan Corbet wrote:
> On Fri, 11 Jan 2019 14:40:59 +0100
> Christian Brauner <christian@xxxxxxxxxx> wrote:
>
> > This documents the Android binderfs filesystem used to dynamically add and
> > remove binder devices that are private to each instance.
> >
> > Signed-off-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
>
> Two quick notes:
>
> > ---
> > /* Changelog */
> > v1:
> > - switch from *.txt to *.rst format
> > ---
> > Documentation/filesystems/binderfs.rst | 70 ++++++++++++++++++++++++++
> > 1 file changed, 70 insertions(+)
> > create mode 100644 Documentation/filesystems/binderfs.rst
>
> You didn't add it to index.rst, so it won't actually become part of the
> docs build.
>
> > diff --git a/Documentation/filesystems/binderfs.rst b/Documentation/filesystems/binderfs.rst
> > new file mode 100644
> > index 000000000000..74a744b42db7
> > --- /dev/null
> > +++ b/Documentation/filesystems/binderfs.rst
> > @@ -0,0 +1,70 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +The Android binderfs Filesystem
> > +===============================
> > +
> > +Android binderfs is a filesystem for the Android binder IPC mechanism. It
> > +allows to dynamically add and remove binder devices at runtime. Binder devices
> > +located in a new binderfs instance are independent of binder devices located in
> > +other binderfs instances. Mounting a new binderfs instance makes it possible
> > +to get a set of private binder devices.
> > +
> > +Mounting binderfs
> > +-----------------
> > +
> > +Android binderfs can be mounted with:
> > +
> > +::
>
> This can be more readably formatted as:
>
> Android binderfs can be mounted with::
>
> I've applied the patches, taking the liberty of fixing both of those
> things up. Thanks!

Thanks Jon! Highly appreciated!

Christian