[PATCH v4 1/5] ov7670: Remove useless use of a ret variable

From: Lubomir Rintel
Date: Tue Jan 15 2019 - 03:55:19 EST


From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

Instead of assigning the return value to ret and then checking and
returning it, just return the value to the caller directly. The success
value is always 0.

Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Acked-by: Lubomir Rintel <lkundrak@xxxxx>

---
drivers/media/i2c/ov7670.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
index 4939a83b50e4..61c47c61c693 100644
--- a/drivers/media/i2c/ov7670.c
+++ b/drivers/media/i2c/ov7670.c
@@ -859,11 +859,7 @@ static int ov7675_set_framerate(struct v4l2_subdev *sd,
/* Recalculate frame rate */
ov7675_get_framerate(sd, tpf);

- ret = ov7670_write(sd, REG_CLKRC, info->clkrc);
- if (ret < 0)
- return ret;
-
- return 0;
+ return ov7670_write(sd, REG_CLKRC, info->clkrc);
}

static void ov7670_get_framerate_legacy(struct v4l2_subdev *sd,
--
2.20.1