Re: [PATCH] Revert "spi: omap2-mcspi: Set FIFO DMA trigger level to word length"

From: Mark Brown
Date: Mon Jan 14 2019 - 19:07:58 EST


On Mon, Jan 14, 2019 at 05:50:34PM -0600, David Lechner wrote:
> On 1/14/19 6:30 AM, Vignesh R wrote:

> > Oops, that's unfortunate. I see ili9225 is using bits_per_word = 16.
> > I believe commit b682cffa3ac6d9d broke spi_transfers where
> > bits_per_word anything other than 8 bits.
> > I don't have ili9225 HW but was able emulate this condition using a SPI
> > flash as slave on AM335x and successfully reproduced the issue. Could
> > you test if this diff[1] helps in fixing the regression without needing
> > to revert commit b682cffa3ac6d9d?

> Yes, this changes fixes the problem. Thanks!

Excellent! Vignesh, can you post a formal patch please and I'll get it
merged?

Attachment: signature.asc
Description: PGP signature