Re: [PATCH] fs/dax: Convert to use vmf_error()

From: Dan Williams
Date: Mon Jan 14 2019 - 17:30:59 EST


On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@xxxxxxx> wrote:
>
> On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > This code is converted to use vmf_error().
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>
> Dan, you are merging DAX patches these days. So probably you should add
> yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.

Sounds good, I'll merge this and get MAINTAINERs fixed up.

> Or I can start
> picking patches for fsdax to my tree if you are too busy but I think your
> tree is easier as there are less chances for conflicts etc.
>
> In either case this patch looks OK to me so feel free to add
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> Honza
>
> > ---
> > fs/dax.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index 48132ec..ed39161 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
> > {
> > if (error == 0)
> > return VM_FAULT_NOPAGE;
> > - if (error == -ENOMEM)
> > - return VM_FAULT_OOM;
> > - return VM_FAULT_SIGBUS;
> > + return vmf_error(error);
> > }
> >
> > /*
> > --
> > 1.9.1
> >
> --
> Jan Kara <jack@xxxxxxxx>
> SUSE Labs, CR