Re: [PATCH v2] xen: Fix x86 sched_clock() interface for xen

From: Boris Ostrovsky
Date: Fri Jan 11 2019 - 15:36:34 EST


On 1/11/19 7:08 AM, Juergen Gross wrote:
> @@ -421,6 +424,11 @@ void xen_restore_time_memory_area(void)
> if (ret != 0)
> pr_notice("Cannot restore secondary vcpu_time_info (err %d)",
> ret);
> +
> +out:
> + /* Need pvclock_resume() before using xen_clocksource_read(). */
> + pvclock_resume();

Do we want to drop it from xen_timer_resume then?

BTW, I ran this code a few times on top of for-linus-4.21 and didn't see
any of the problems that Hans described. I didn't do LM, only
save/restore, but I'd think it shouldn't make any difference.

-boris