Re: [PATCH] printk: Add caller information to printk() output.

From: Kevin Hilman
Date: Fri Jan 11 2019 - 14:34:33 EST


Dmitry Vyukov <dvyukov@xxxxxxxxxx> writes:

> On Wed, Jan 2, 2019 at 5:09 PM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
>>
>> On Tue, Dec 18, 2018 at 9:58 AM Sergey Senozhatsky
>> <sergey.senozhatsky.work@xxxxxxxxx> wrote:
>> >
>> > On (12/18/18 09:39), Petr Mladek wrote:
>> > >
>> > > Sergey, are you okay with this squashed patch, please?
>> > >
>> >
>> > Yeah. There are several minor nitpicks, but here is my
>> > Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>> >
>> >
>> > One final question - can syzbot folks confirm that the patch
>> > helps? Just curious.
>>
>> This slip through the cracks. Tetsuo pinged me and I am testing now.
>> Need to create a set of tests and update parsing code to handle this.
>
> I've pushed support for CONFIG_PRINTK_CALLER to syzkaller/syzbot:
> https://github.com/google/syzkaller/commit/7da2392541a49c3f17b2e7d24e04b84d72b965fb
> Let's see what happens. Limited local testing shows that it's working
> as intended and significatly improves quality of reports and ability
> to make sense out of kernel output.
>
> Tetsuo, thanks for your great persistence with this change!
> Sergey, Petr, thanks for reviews!
>
> +Fengguang, Kevin, maybe you will find this useful for 0-day/kernel-ci.

Yes, will definitely give it a try.

Kevin