RE: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in ixgbe_reset_hw_82599()

From: Bowers, AndrewX
Date: Fri Jan 11 2019 - 13:46:25 EST


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On
> Behalf Of Jiri Kosina
> Sent: Wednesday, January 2, 2019 11:21 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in
> ixgbe_reset_hw_82599()
>
> From: Jiri Kosina <jkosina@xxxxxxx>
>
> ixgbe_reset_hw_82599() resets the value of hw->mac.num_rar_entries to
> pre-defined value of 128. Let's get rid of that hardcoded literal, and use
> IXGBE_82599_RAR_ENTRIES instead, the same way the normal initialization
> path does.
>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>