Re: [PATCH 2/6] dt-bindings: clock: Add DT bindings for Actions Semi S500 CMU

From: Rob Herring
Date: Fri Jan 11 2019 - 09:56:48 EST


On Tue, Jan 01, 2019 at 12:25:13AM +0530, Manivannan Sadhasivam wrote:
> From: Edgar Bernardi Righi <edgar.righi@xxxxxxxxxxxxx>
>
> Add devicetree bindings for Actions Semi S500 Clock Management Unit.
>
> Signed-off-by: Edgar Bernardi Righi <edgar.righi@xxxxxxxxxxxxx>
> [Mani: Documented S500 CMU compatible]
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
>
> Rob, I have removed your Reviewed-by tag for this patch since the
> earlier revision contained only bindings constants and lacked the
> compatible documentation, which is added now.
>
> .../bindings/clock/actions,owl-cmu.txt | 7 +-
> include/dt-bindings/clock/actions,s500-cmu.h | 78 +++++++++++++++++++
> 2 files changed, 82 insertions(+), 3 deletions(-)
> create mode 100644 include/dt-bindings/clock/actions,s500-cmu.h
>
> diff --git a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
> index 2ef86ae96df8..86183f559022 100644
> --- a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
> +++ b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
> @@ -2,13 +2,14 @@
>
> The Actions Semi Owl Clock Management Unit generates and supplies clock
> to various controllers within the SoC. The clock binding described here is
> -applicable to S900 and S700 SoC's.
> +applicable to S900,S700 and S500 SoC's.

space needed after the ','.

With that,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>