Re: [PATCH] drivers/usb/storage: Remove duplicate headers

From: Greg KH
Date: Fri Jan 11 2019 - 04:10:55 EST


On Thu, Jan 10, 2019 at 12:40:07PM +0530, Sabyasachi Gupta wrote:
> Remove duplicate headers which are included more than once.
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx>
> ---
> drivers/usb/storage/datafab.c | 1 -
> drivers/usb/storage/ene_ub6250.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
> index 09353be..4b1bd56 100644
> --- a/drivers/usb/storage/datafab.c
> +++ b/drivers/usb/storage/datafab.c
> @@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
> }
>
> static struct us_unusual_dev datafab_unusual_dev_list[] = {
> -# include "unusual_datafab.h"
> { } /* Terminating entry */
> };

Nope, this breaks things :(