Re: [PATCH 09/41] scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 9:38 AM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can ack or review this patch, please?
>
> Thanks
> --
> Gustavo
>
> On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Notice that I replaced "Fall through !!!" with a "fall through"
> > annotation, which is what GCC is expecting to find.
> >
> > Addresses-Coverity-ID: 114971 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/scsi/bfa/bfa_fcpim.c | 6 +++---
> > Â 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c
> > index 2c85f5b1f9c1..7e996bcf026c 100644
> > --- a/drivers/scsi/bfa/bfa_fcpim.c
> > +++ b/drivers/scsi/bfa/bfa_fcpim.c
> > @@ -2586,6 +2586,7 @@ bfa_ioim_send_ioreq(struct bfa_ioim_s *ioim)
> > ÂÂÂÂÂ case FCP_IODIR_RW:
> > ÂÂÂÂÂÂÂÂÂ bfa_stats(itnim, input_reqs);
> > ÂÂÂÂÂÂÂÂÂ bfa_stats(itnim, output_reqs);
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ default:
> > ÂÂÂÂÂÂÂÂÂ bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa));
> > ÂÂÂÂÂ }
> > @@ -2820,6 +2821,7 @@ bfa_ioim_isr(struct bfa_s *bfa, struct bfi_msg_s *m)
> > ÂÂÂÂÂ case BFI_IOIM_STS_TIMEDOUT:
> > ÂÂÂÂÂÂÂÂÂ bfa_stats(ioim->itnim, iocomp_timedout);
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ case BFI_IOIM_STS_ABORTED:
> > ÂÂÂÂÂÂÂÂÂ rsp->io_status = BFI_IOIM_STS_ABORTED;
> > ÂÂÂÂÂÂÂÂÂ bfa_stats(ioim->itnim, iocomp_aborted);
> > @@ -3215,9 +3217,7 @@ bfa_tskim_sm_cleanup_qfull(struct bfa_tskim_s *tskim,
> > ÂÂÂÂÂ switch (event) {
> > ÂÂÂÂÂ case BFA_TSKIM_SM_DONE:
> > ÂÂÂÂÂÂÂÂÂ bfa_reqq_wcancel(&tskim->reqq_wait);
> > -ÂÂÂÂÂÂÂ /*
> > -ÂÂÂÂÂÂÂÂ * Fall through !!!
> > -ÂÂÂÂÂÂÂÂ */
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ case BFA_TSKIM_SM_QRESUME:
> > ÂÂÂÂÂÂÂÂÂ bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup);
> > ÂÂÂÂÂÂÂÂÂ bfa_tskim_send_abort(tskim);