Re: [PATCH 33/41] scsi: osd: osd_initiator: mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 6:07 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can ack or review this patch, please?
>
> Thanks
> --
> Gustavo
>
> On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/scsi/osd/osd_initiator.c | 3 ++-
> > Â 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
> > index 60cf7c5eb880..cb26f26d5ec1 100644
> > --- a/drivers/scsi/osd/osd_initiator.c
> > +++ b/drivers/scsi/osd/osd_initiator.c
> > @@ -1849,6 +1849,7 @@ int osd_req_decode_sense_full(struct osd_request *or,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ 32, 1, dump, sizeof(dump), true);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ OSD_SENSE_PRINT2("response_integrity [%s]\n", dump);
> > ÂÂÂÂÂÂÂÂÂ }
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂÂÂÂ case osd_sense_attribute_identification:
> > ÂÂÂÂÂÂÂÂÂ {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ struct osd_sense_attributes_data_descriptor
> > @@ -1879,7 +1880,7 @@ int osd_req_decode_sense_full(struct osd_request *or,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ attr_page, attr_id);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ }
> > ÂÂÂÂÂÂÂÂÂ }
> > -ÂÂÂÂÂÂÂ /*These are not legal for OSD*/
> > +ÂÂÂÂÂÂÂ /* fall through - These are not legal for OSD */
> > ÂÂÂÂÂÂÂÂÂ case scsi_sense_field_replaceable_unit:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ OSD_SENSE_PRINT2("scsi_sense_field_replaceable_unit\n");
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ break;