Re: [PATCH] ARM: irq: Add IRQ_SET_MASK_OK_DONE handling in migrate_one_irq()

[Dietmar Eggemann]

On 1/9/19 5:21 PM, Marc Zyngier wrote:
> On 09/01/2019 15:47, Dietmar Eggemann wrote:
> > Hi Marc,
> >
> > On 1/8/19 3:16 PM, Marc Zyngier wrote:
> > > Hi Dietmar,
> > >
> > > On 08/01/2019 13:58, Dietmar Eggemann wrote:

[...]

> > > On the arm64 side, we've solved the exact same issue by getting rid of
> > > this code and using the generic implementation. See 217d453d473c5
> > > ("arm64: fix a migrating irq bug when hotplug cpu"), which uses
> > > irq_migrate_all_off_this_cpu instead.
> > >
> > > I'm not sure there is much value in not using the core code in this case.
> >
> > Thanks for the hint! Much more elegant! I tried the following on TC2 and
> > it worked just fine. I'm not aware on any drawbacks of using the generic
> > irq migration for Arm32 as well.
>
> [...]
>
> Sounds great! Can you put it in a proper patch and resend it?

Yes. I renamed the patch to "arm: fix a migrating irq bug when hotplug 
cpu" so it's closer to its arm64 counterpart patch.

https://lore.kernel.org/lkml/20190110100922.20280-1-dietmar.eggemann@xxxxxxx/