Re: [PATCH 4/5] csky: fixup compile error with pte_alloc

From: Linus Torvalds
Date: Tue Jan 08 2019 - 12:33:32 EST


On Tue, Jan 8, 2019 at 8:27 AM <guoren@xxxxxxxxxx> wrote:
>
> + for (i = 0; i < PAGE_SIZE/sizeof(pte_t); i++)
> + (pte + i)->pte_low = _PAGE_GLOBAL;

When I first read this, I went "hmm. pte_high is not initialized".

But csky doesn't have a pte_high, and it seems that csky and SH both
decided to call their (single-word) pte member 'pte_low'.

Which is a bit odd, but whatever.

Other than that oddity, it looks fine to me. I assume I'll get a pull
request sooner or later,

Linus