Re: [PATCH v5 15/15] KVM: s390: start using the GIB

[Michael Mueller]

On 02.01.19 18:45, Pierre Morel wrote:
> On 19/12/2018 20:17, Michael Mueller wrote:
> > By initializing the GIB, it will be used by the kvm host.
> >
> > Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxx>
> > ---
> > Â arch/s390/kvm/kvm-s390.c | 8 +++++++-
> > Â 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> > index 2d10e175862c..777c8a87d81c 100644
> > --- a/arch/s390/kvm/kvm-s390.c
> > +++ b/arch/s390/kvm/kvm-s390.c
> > @@ -428,16 +428,22 @@ int kvm_arch_init(void *opaque)
> > ÂÂÂÂÂÂÂÂÂ goto out_debug_unreg;
> > ÂÂÂÂÂ }
> > +ÂÂÂ rc = kvm_s390_gib_init(GAL_ISC);
> > +ÂÂÂ if (rc)
> > +ÂÂÂÂÂÂÂ goto out_debug_unreg;
> > +
>
> Since it is the last introduced I have a preference to put the gib 
> initialization after any existing initialization.
> it does not have influence them.
>
> > ÂÂÂÂÂ kvm_s390_cpu_feat_init();
> > ÂÂÂÂÂ /* Register floating interrupt controller interface. */
> > ÂÂÂÂÂ rc = kvm_register_device_ops(&kvm_flic_ops, KVM_DEV_TYPE_FLIC);
> > ÂÂÂÂÂ if (rc) {
> > ÂÂÂÂÂÂÂÂÂ pr_err("Failed to register FLIC rc=%d\n", rc);
> > -ÂÂÂÂÂÂÂ goto out_debug_unreg;
> > +ÂÂÂÂÂÂÂ goto out_gib_destroy;
>
> It is not a big problem but would make the patch more smaller by 
> gathering all changes.

I will move that behind the FLIC registraion.

> > ÂÂÂÂÂ }
> > ÂÂÂÂÂ return 0;
> > +out_gib_destroy:
> > +ÂÂÂ kvm_s390_gib_destroy();
> > Â out_debug_unreg:
> > ÂÂÂÂÂ debug_unregister(kvm_s390_dbf);
> > ÂÂÂÂÂ return rc;
>
> with these changes.
> Reviewed-by: Pierre Morel<pmorel@xxxxxxxxxxxxx>