Re: [PATCH] drm/bridge/panel: Remove duplicate header

From: Laurent Pinchart
Date: Wed Dec 26 2018 - 04:41:23 EST


Hi Brajeswar,

Thank you for the patch.

On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> Remove drm/drm_panel.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@xxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba213ef6..402b318eeeb2 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_encoder.h>
> #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>

While at it, how about sorting headers alphabetically to make sure this won't
happen again ?

With that change,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> struct panel_bridge {
> struct drm_bridge bridge;

--
Regards,

Laurent Pinchart