[PATCH v2] rtl8712: add a check for the status of register_netdev

From: Kangjie Lu
Date: Tue Dec 25 2018 - 21:40:29 EST


register_netdev() may fail, so let's check its return value, and if it
fails, issue an error message.

Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
---
drivers/staging/rtl8712/hal_init.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
index 7cdd609cab6c..ca0858660a45 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -32,10 +32,10 @@
static void rtl871x_load_fw_cb(const struct firmware *firmware, void *context)
{
struct _adapter *padapter = context;
+ struct usb_device *udev = padapter->dvobjpriv.pusbdev;

complete(&padapter->rtl8712_fw_ready);
if (!firmware) {
- struct usb_device *udev = padapter->dvobjpriv.pusbdev;
struct usb_interface *pusb_intf = padapter->pusb_intf;

dev_err(&udev->dev, "r8712u: Firmware request failed\n");
@@ -45,7 +45,8 @@ static void rtl871x_load_fw_cb(const struct firmware *firmware, void *context)
}
padapter->fw = firmware;
/* firmware available - start netdev */
- register_netdev(padapter->pnetdev);
+ if (register_netdev(padapter->pnetdev))
+ dev_err(&udev->dev, "r8712u: Registering netdev failed\n");
}

static const char firmware_file[] = "rtlwifi/rtl8712u.bin";
--
2.17.2 (Apple Git-113)