RE: [PATCH] clk: imx: imx7ulp: use struct_size() in kzalloc()

From: Aisheng Dong
Date: Mon Dec 24 2018 - 04:03:15 EST


> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@xxxxxxxxxxxxxx]
> Sent: Monday, December 24, 2018 2:40 PM
>
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> void *entry[];
> };
>
> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>
> Instead of leaving these open-coded and prone to type mistakes, we can now
> use the new struct_size() helper:
>
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx>

Regards
Dong Aisheng