Re: [PATCH 2/2] mfd: tps65218.c: Add input voltage options

From: Lee Jones
Date: Mon Dec 24 2018 - 01:33:03 EST


On Sun, 23 Dec 2018, Tony Lindgren wrote:

> * Lee Jones <lee.jones@xxxxxxxxxx> [181221 11:01]:
> > On Tue, 18 Dec 2018, Christian Hohnstaedt wrote:
> >
> > > These options apply to all regulators in this chip.
> > >
> > > strict-supply-voltage:
> > > Set STRICT flag in CONFIG1
> > > under-voltage-limit:
> > > Select 2.75, 2.95, 3.25 or 3.35 V UVLO in CONFIG1
> > > under-voltage-hysteresis:
> > > Select 200mV or 400mV UVLOHYS in CONFIG2
> > >
> > > Signed-off-by: Christian Hohnstaedt <Christian.Hohnstaedt@xxxxxxxx>
> > > ---
> > > drivers/mfd/tps65218.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 46 insertions(+)
> >
> > This needs a close review by Tony and any of the other OMAP guys.
>
> Adding Keerthy to Cc, he's probably the best person to review these
> changes.

But you've dropped the patch, so all he has it a commit log to review?

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog