Re: [PATCH 7/7] drm: Complete remove drm_mode_object dependency

From: kbuild test robot
Date: Sat Dec 22 2018 - 15:26:59 EST


Hi Shayenne,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robclark/msm-next]
[also build test ERROR on v4.20-rc7 next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Shayenne-Moura/drm-Remove-drm_mode_object-dependency-from-drm_display_mode/20181222-065838
base: git://people.freedesktop.org/~robclark/linux msm-next
config: i386-randconfig-a3-12211242 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers/gpu/drm/drm_modes.c: In function 'drm_mode_destroy':
>> drivers/gpu/drm/drm_modes.c:90:39: error: 'struct drm_display_mode' has no member named 'base'
drm_mode_object_unregister(dev, &mode->base);
^
drivers/gpu/drm/drm_modes.c: In function 'drm_mode_copy':
drivers/gpu/drm/drm_modes.c:909:14: error: 'struct drm_display_mode' has no member named 'base'
int id = dst->base.id;
^
drivers/gpu/drm/drm_modes.c:913:5: error: 'struct drm_display_mode' has no member named 'base'
dst->base.id = id;
^

vim +90 drivers/gpu/drm/drm_modes.c

8bd441b2 Daniel Vetter 2014-01-23 77
8bd441b2 Daniel Vetter 2014-01-23 78 /**
8bd441b2 Daniel Vetter 2014-01-23 79 * drm_mode_destroy - remove a mode
8bd441b2 Daniel Vetter 2014-01-23 80 * @dev: DRM device
8bd441b2 Daniel Vetter 2014-01-23 81 * @mode: mode to remove
8bd441b2 Daniel Vetter 2014-01-23 82 *
f5aabb97 Daniel Vetter 2014-01-23 83 * Release @mode's unique ID, then free it @mode structure itself using kfree.
8bd441b2 Daniel Vetter 2014-01-23 84 */
8bd441b2 Daniel Vetter 2014-01-23 85 void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode)
8bd441b2 Daniel Vetter 2014-01-23 86 {
8bd441b2 Daniel Vetter 2014-01-23 87 if (!mode)
8bd441b2 Daniel Vetter 2014-01-23 88 return;
8bd441b2 Daniel Vetter 2014-01-23 89
7c8f6d25 Dave Airlie 2016-04-15 @90 drm_mode_object_unregister(dev, &mode->base);
8bd441b2 Daniel Vetter 2014-01-23 91
8bd441b2 Daniel Vetter 2014-01-23 92 kfree(mode);
8bd441b2 Daniel Vetter 2014-01-23 93 }
8bd441b2 Daniel Vetter 2014-01-23 94 EXPORT_SYMBOL(drm_mode_destroy);
8bd441b2 Daniel Vetter 2014-01-23 95

:::::: The code at line 90 was first introduced by commit
:::::: 7c8f6d2577c7565f67ba3f6b9b76f7422710d66e drm/mode: rework drm_mode_object_put to drm_mode_object_unregister.

:::::: TO: Dave Airlie <airlied@xxxxxxxxxx>
:::::: CC: Dave Airlie <airlied@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip