Re: [PATCH] mfd: mc13xxx: fix a missing check of a register-read failure

From: Lee Jones
Date: Fri Dec 21 2018 - 09:52:16 EST


On Thu, 20 Dec 2018, Kangjie Lu wrote:

> When mc13xxx_reg_read() fails, "old_adc0" is uninitialized and will
> contain random value. Further execution uses "old_adc0" even when
> mc13xxx_reg_read() fails.
> The fix checks the return value of mc13xxx_reg_read(), and exits
> the execution when it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
> ---
> drivers/mfd/mc13xxx-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog