Re: [PATCH V5 2/4] rtc: add i.MX system controller RTC support

From: Alexandre Belloni
Date: Fri Dec 21 2018 - 04:24:54 EST


On 20/12/2018 08:56:16+0000, Anson Huang wrote:
> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> inside, the system controller is in charge of controlling power,
> clock and secure rtc etc..
>
> This patch adds i.MX system controller RTC driver support,
> Linux kernel has to communicate with system controller via MU
> (message unit) IPC to set/get RTC time and other alarm functions,
> since the RTC set time needs to be done in secure EL3 mode (required
> by system controller firmware) and alarm functions needs to be done
> with general MU IRQ handle, these depend on other components which
> are NOT ready, so this patch ONLY enables the RTC time read.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> ---
> ChangeLog since V4:
> - Add dependency on IMX_SCU to avoid compile error when IMX_SCU is NOT enabled;
> - Use dev_err instead of pr_err;
> - Remove unneccssary different errors check in imx_scu_get_handle which is already done in API.
> ---
> drivers/rtc/Kconfig | 7 ++++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-imx-sc.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 99 insertions(+)
> create mode 100644 drivers/rtc/rtc-imx-sc.c
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com