Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings
From: Jorge Ramirez
Date: Fri Dec 21 2018 - 02:40:41 EST
On 12/20/18 18:37, Jack Pham wrote:
Hi Rob, Jorge,
On Thu, Dec 20, 2018 at 11:05:31AM -0600, Rob Herring wrote:
On Fri, Dec 07, 2018 at 10:55:57AM +0100, Jorge Ramirez-Ortiz wrote:
Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY
controller embedded in QCS404.
Based on Sriharsha Allenki's <sallenki@xxxxxxxxxxxxxx> original
definitions.
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx>
Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>
---
.../devicetree/bindings/usb/qcom,usb-ssphy.txt | 78 ++++++++++++++++++++++
1 file changed, 78 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
diff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
new file mode 100644
index 0000000..fcf4e01
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
@@ -0,0 +1,78 @@
+Qualcomm Synopsys 1.0.0 SS phy controller
+===========================================
+
+Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm
+chipsets
+
+Required properties:
+
+- compatible:
+ Value type: <string>
+ Definition: Should contain "qcom,usb-ssphy".
What is "qcom,dwc3-ss-usb-phy" which already exists then?
Uh, apparently only the bindings doc is there but the driver never
landed. I guess it fell through the cracks nearly 4 years ago.
https://lore.kernel.org/patchwork/patch/499502/
Jorge, does Andy's version of this driver at all resemble what can be
used for QCS404?
the drivers seem quite different but I'll give it a go as well and
compare (it is my understanding that the controller is the same - I will
have access to the hardware documentation soon to compare)
but I'll come back to you on this.
Jack