Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

From: Pavel Machek
Date: Wed Dec 19 2018 - 17:03:32 EST


Hi!

> >I don't think a user needs nor would want to have 24 different LED nodes with 24 different brightness files.
> >Or with the LP5036 that would have 36 LED nodes.
> >
> >Table 1 in the data sheet shows how the outputs map to the control banks to the LED registers.
>
> Some time ago we had discussion with Vesa Jääskeläinen about possible
> approaches to RGB LEDs [0]. What seemed to be the most suitable
> variation of the discussed out-of-tree approach was the "color" property
> and array of color triplets defined in Device Tree per each color.
>
> Please refer to [0] for the details.
>
> [0] https://lkml.org/lkml/2018/11/9/938

Yes, plus I also have the set of HSV patches somewhere... and they
work, but I found out that HSV->RGB conversion results in loss of precision.

We may want to do something like that.

But we need to do it once, in a driver core. We obviously don't want
each driver having different version of RGB support.

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature