Re: [PATCH v2] regulator: palmas: fix a missing check of return value

From: Mark Brown
Date: Wed Dec 19 2018 - 12:52:02 EST


On Wed, Dec 19, 2018 at 11:11:39AM -0600, Kangjie Lu wrote:
> If palmas_smps_read() fails, we should not use the read data in "reg"
> which may contain random value. The fix inserts a check for the return
> value of palmas_smps_read(): If it fails, we return the error code
> upstream and stop using "reg".

Ah, thanks - I'd actually already applied the earlier version!

Attachment: signature.asc
Description: PGP signature