Re: [PATCH v3 0/5] alpha: system call table generation support

From: Matt Turner
Date: Wed Dec 19 2018 - 10:59:24 EST


On Fri, Dec 14, 2018 at 10:18 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>
> Hi Folks,
>
> On Tue, 13 Nov 2018 at 15:02, Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
> >
> > The purpose of this patch series is, we can easily
> > add/modify/delete system call table support by cha-
> > nging entry in syscall.tbl file instead of manually
> > changing many files. The other goal is to unify the
> > system call table generation support implementation
> > across all the architectures.
> >
> > The system call tables are in different format in
> > all architecture. It will be difficult to manually
> > add, modify or delete the system calls in the resp-
> > ective files manually. To make it easy by keeping a
> > script and which'll generate uapi header file and
> > syscall table file.
> >
> > syscall.tbl contains the list of available system
> > calls along with system call number and correspond-
> > ing entry point. Add a new system call in this arch-
> > itecture will be possible by adding new entry in the
> > syscall.tbl file.
> >
> > Adding a new table entry consisting of:
> > - System call number.
> > - ABI.
> > - System call name.
> > - Entry point name.
> >
> > ARM, s390 and x86 architecuture does exist the sim-
> > ilar support. I leverage their implementation to
> > come up with a generic solution.
> >
> > I have done the same support for work for ia64, m68k,
> > microblaze, mips, parisc, powerpc, sh, sparc and xtensa.
> > Below mentioned git repository contains more details
> > about the workflow.
> >
> > https://github.com/frzkhn/system_call_table_generator/
> >
> > Finally, this is the ground work to solve the Y2038
> > issue. We need to add two dozen of system calls to
> > solve Y2038 issue. So this patch series will help to
> > add new system calls easily by adding new entry in
> > the syscall.tbl.
> >
> > changes since v2:
> > - changed from generic-y to generated-y in Kbuild.
> > - made changes in syscall.tbl for removing entry -
> > alpha_ni_syscall.
> >
> > changes since v1:
> > - optimized/updated the syscall table generation
> > scripts.
> > - fixed all mixed indentation issues in syscall.tbl.
> > - added "comments" in syscall.tbl.
> > - enclosed __NR_sycalls macro with __KERNEL__.
> > - added missing new line.
> >
> > Firoz Khan (5):
> > alpha: move __IGNORE* entries to non uapi header
> > alpha: remove CONFIG_OSF4_COMPAT flag from syscall table
> > alpha: add __NR_syscalls along with NR_SYSCALLS
> > alpha: add system call table generation support
> > alpha: generate uapi header and syscall table header files
>
> Could someone review this patch series and queue it for 4.21
> through alpha tree would be great.

Thank you! I'll take a look.