Re: [PATCH v2 1/3] sched/fair: fix rounding issue for asym packing

From: Valentin Schneider
Date: Wed Dec 19 2018 - 10:11:48 EST


On 19/12/2018 15:05, Vincent Guittot wrote:
[...]
>> True, I had a look at the trace and there doesn't seem to be any running
>> task on that CPU. That's a separate matter however - the rounding issues
>> can happen regardless of the wl values.
>
> But it means that the rounding fix +1 works and your problems comes
> from something else

Oh yes, I never said it didn't work - I was doing some investigation on
the reason as to why we'd need this fix, because it's wasn't explicit from
the commit message.

The rounding errors are countered by the +1, yes, but I'd rather remove
the errors altogether and go for the snippet I suggested in my previous
reply.