Re: [PATCH] vxge: ensure data0 is initialized in when fetching firmware version information

From: David Miller
Date: Wed Dec 19 2018 - 01:03:57 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 18 Dec 2018 15:19:47 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently variable data0 is not being initialized so a garbage value is
> being passed to vxge_hw_vpath_fw_api and this value is being written to
> the rts_access_steer_data0 register. There are other occurrances where
> data0 is being initialized to zero (e.g. in function
> vxge_hw_upgrade_read_version) so I think it makes sense to ensure data0
> is initialized likewise to 0.
>
> Detected by CoverityScan, CID#140696 ("Uninitialized scalar variable")
>
> Fixes: 8424e00dfd52 ("vxge: serialize access to steering control register")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.