Re: [PATCH 2/3] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race

From: Andrew Morton
Date: Tue Dec 18 2018 - 17:11:00 EST


On Mon, 17 Dec 2018 16:17:52 -0800 Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:

> ...
>
> > As you suggested in a comment to the subsequent patch, it would be better to
> > combine the patches and remove the dead code when it becomes dead. I will
> > work on that. Actually some of the code in patch 3 applies to patch 1 and
> > some applies to patch 2. So, it will not be simply combining patch 2 and 3.
>
> On second thought, the cleanups in patch 3 only apply to patch 2. So, just
> combining those two patches with a slightly updated commit message as below
> makes the most sense.

All confused. I dropped the current version, let's try again.

This:

> Hoping to get more comments on the overall direction and locking changes
> of this and the previous patch.

and this:

> Cc: <stable@xxxxxxxxxxxxxxx>
> Fixes: ebed4bfc8da8 ("hugetlb: fix absurd HugePages_Rsvd")

make for a hot combination. Could people please prioritize review of
this code?

Perhaps a refresh and resend is in order.