Re: [PATCH] printk: Add caller information to printk() output.

[Sergey Senozhatsky]

On (12/18/18 06:05), Tetsuo Handa wrote:
> +#ifdef CONFIG_PRINTK_CALLER
> +static size_t print_caller(u32 id, char *buf)
> +{
> +	char from[12];
> +
> +	snprintf(from, sizeof(from), "%c%u",
> +		 id & 0x80000000 ? 'C' : 'T', id & ~0x80000000);
> +	return sprintf(buf, "[%6s]", from);
> +}

A nitpick:

s/from/caller/g   :)


> +	  Selecting this option causes "thread id" (if in task context) or
> +	  "processor id" (if not in task context) of the printk() messages
> +	  to be added.

Would the following wording be a bit simpler?

  "Selecting this option causes printk() to add a caller "thread id" (if
   in task context) or a caller "processor id" (if not in task context)
   to every message."

	-ss