Re: [PATCH v6 08/27] csky: define syscall_get_arch()

From: Guo Ren
Date: Thu Dec 13 2018 - 23:44:30 EST


Thx Dmitry,

Reviewed-by: Guo Ren <guoren@xxxxxxxxxx>

On Thu, Dec 13, 2018 at 08:22:07PM +0300, Dmitry V. Levin wrote:
> syscall_get_arch() is required to be implemented on all architectures
> in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO
> request.
>
> Cc: Guo Ren <guoren@xxxxxxxxxx>
> Cc: Paul Moore <paul@xxxxxxxxxxxxxx>
> Cc: Eric Paris <eparis@xxxxxxxxxx>
> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> Cc: Elvira Khabirova <lineprinter@xxxxxxxxxxxx>
> Cc: Eugene Syromyatnikov <esyr@xxxxxxxxxx>
> Cc: linux-audit@xxxxxxxxxx
> Signed-off-by: Dmitry V. Levin <ldv@xxxxxxxxxxxx>
> ---
>
> Notes:
> v6: unchanged
>
> arch/csky/include/asm/syscall.h | 7 +++++++
> include/uapi/linux/audit.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/csky/include/asm/syscall.h b/arch/csky/include/asm/syscall.h
> index 926a64a8b4ee..d637445737b7 100644
> --- a/arch/csky/include/asm/syscall.h
> +++ b/arch/csky/include/asm/syscall.h
> @@ -6,6 +6,7 @@
> #include <linux/sched.h>
> #include <linux/err.h>
> #include <abi/regdef.h>
> +#include <uapi/linux/audit.h>
>
> static inline int
> syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
> @@ -68,4 +69,10 @@ syscall_set_arguments(struct task_struct *task, struct pt_regs *regs,
> memcpy(&regs->a1 + i * sizeof(regs->a1), args, n * sizeof(regs->a0));
> }
>
> +static inline int
> +syscall_get_arch(void)
> +{
> + return AUDIT_ARCH_CSKY;
> +}
> +
> #endif /* __ASM_SYSCALL_H */
> diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
> index 72aeea0a740d..55904a40d768 100644
> --- a/include/uapi/linux/audit.h
> +++ b/include/uapi/linux/audit.h
> @@ -384,6 +384,7 @@ enum {
> #define AUDIT_ARCH_C6X (EM_TI_C6000|__AUDIT_ARCH_LE)
> #define AUDIT_ARCH_C6XBE (EM_TI_C6000)
> #define AUDIT_ARCH_CRIS (EM_CRIS|__AUDIT_ARCH_LE)
> +#define AUDIT_ARCH_CSKY (EM_CSKY|__AUDIT_ARCH_LE)
> #define AUDIT_ARCH_FRV (EM_FRV)
> #define AUDIT_ARCH_I386 (EM_386|__AUDIT_ARCH_LE)
> #define AUDIT_ARCH_IA64 (EM_IA_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
> --
> ldv