Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

From: Jeremy Fertic
Date: Thu Dec 13 2018 - 17:06:35 EST


On Wed, Dec 12, 2018 at 11:19:49AM +0300, Dan Carpenter wrote:
> On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote:
> > ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being
> > used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc
> > input that shares the ldac pin. Only set these bits if an ldac pin is not
> > being used.
> >
> > Signed-off-by: Jeremy Fertic <jeremyfertic@xxxxxxxxx>
>
> Huh... This bug has always been there...
>
> Fixes: 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9 driver")
>
> regards,
> dan carpenter
>

Should I include this Fixes tag in v2? I wasn't sure how important this was
in staging. I think most of the patches in this series fix bugs that date
back to the introduction of the driver.