Re: [PATCH net V3 0/3] Fix various issue of vhost

From: Michael S. Tsirkin
Date: Thu Dec 13 2018 - 09:32:44 EST


On Thu, Dec 13, 2018 at 10:53:36AM +0800, Jason Wang wrote:
> Hi:
>
> This series tries to fix various issues of vhost:
>
> - Patch 1 adds a missing write barrier between used idx updating and
> logging.
> - Patch 2-3 brings back the protection of device IOTLB through vq
> mutex, this fixes possible use after free in device IOTLB entries.
>
> Please consider them for -stable.

Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

> Thanks
>
> Changes from V2:
> - drop dirty page fix and make it for net-next
> Changes from V1:
> - silent compiler warning for 32bit.
> - use mutex_trylock() on slowpath instead of mutex_lock() even on fast
> path.
>
> Jason Wang (3):
> vhost: make sure used idx is seen before log in vhost_add_used_n()
> vhost_net: switch to use mutex_trylock() in vhost_net_busy_poll()
> Revert "net: vhost: lock the vqs one by one"
>
> drivers/vhost/net.c | 8 +++++++-
> drivers/vhost/vhost.c | 23 +++++++++++++++++++----
> 2 files changed, 26 insertions(+), 5 deletions(-)
>
> --
> 2.17.1