Re: [PATCH] gnss: sirf: fix activation retry handling

From: Johan Hovold
Date: Thu Dec 13 2018 - 08:35:00 EST


On Sun, Dec 09, 2018 at 08:58:02PM +0100, Andreas Kemnade wrote:
> Hi,
>
> On Wed, 5 Dec 2018 11:21:49 +0100
> Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> > Fix activation helper which would return -ETIMEDOUT even if the last
> > retry attempt was successful.
> >
> > Also change the semantics of the retries variable so that it actually
> > holds the number of retries (rather than tries).

> Sounds sane. I rebased my patch series on top of it and improved my
> testing script (the manual on/off toggle in between was not working
> properly)

That's great. And thanks for testing. I'm a bit short on time at the
moment, but will try to take at least a quick look at your v2 today.

Johan