Re: [PATCH] staging: erofs: Add a blank line after declarations

From: Gao Xiang
Date: Wed Dec 12 2018 - 20:51:54 EST


Hi Sungkyung,

On 2018/12/12 23:50, Sungkyung Kim wrote:
> Fix a warning from checkpathch.pl: 'Missing a blank line after
> declarations'
>
> Signed-off-by: Sungkyung Kim <jotun9935@xxxxxxxxx>
> ---
> drivers/staging/erofs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index 04c61a9d7b76..82b6ad5badff 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,
> if (inode->i_state & I_NEW) {
> int err;
> struct erofs_vnode *vi = EROFS_V(inode);
> +

Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?

If not, could you have time check the other files? That is my personal thought, and
I cc-ed the staging mailing list as well.

Thanks,
Gao Xiang

> vi->nid = nid;
>
> err = fill_inode(inode, isdir);
>