Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

From: Fabio Estevam
Date: Wed Dec 12 2018 - 07:51:47 EST


Hi Anson,

On Wed, Dec 12, 2018 at 10:49 AM Anson Huang <anson.huang@xxxxxxx> wrote:

> Since the datasheet of isl29018 states the vdda and vddd MUST be shorted externally, and the later chips even remove vdda, ONLY has vdd one supply, so I think adding vdda does NOT make enough sense. Looks like the vcc they added is just for prepare, the driver did NOT support regulator operation at that time. So can we just use vcc in driver accordingly? Do we have to use the name âVDDâ in datasheet for regulator name?

Ok, understood. In this case, I would suggest keeping the existing name.