Re: [PATCH] drivers: staging: erofs: Fix styling issues

From: Gao Xiang
Date: Tue Dec 11 2018 - 04:18:39 EST


Hi Aaron,

On 2018/12/11 17:06, Aaron Strahlberger wrote:
> Fixed following checkpatch.pl styling issues:
>
> - 17x CHECK: Alignment should match open parenthesis
> - 7x CHECK: Comparison to NULL could be written ...
> - 1x CHECK: Lines should not end with a '('
> - 1x CHECK: Please use a blank line after ...
>
> Signed-off-by: Aaron Strahlberger <aaron.strahlberger@xxxxxxxxx>
> Signed-off-by: Julius Wiedmann <julius.wiedmann@xxxxxx>
> Signed-off-by: Dominik Huber <domi250@xxxxxx>

Thanks for taking time to work on this submitted patch. :)

As a matter of practice, it is perfered to keep each patch
fixes one kind of these issues you found...separate into 4 patches could be better...

In addition, you need send to Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
for upstream...

Thanks,
Gao Xiang