RE: Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

From: MyungJoo Ham
Date: Mon Dec 10 2018 - 20:43:26 EST


> Hi Lukasz,
>
> On 2018ë 12ì 05ì 20:05, Lukasz Luba wrote:
> > The patch prepares devfreq device for handling suspend/resume
> > functionality. The new fields will store needed information during this
> > process. Devfreq framework handles opp-suspend DT entry and there is no
> > need of modyfications in the drivers code. It uses atomic variables to
> > make sure no race condition affects the process.
> >
> > Suggested-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
> > Suggested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/devfreq/devfreq.c | 47 +++++++++++++++++++++++++++++++++++++++++------
> > include/linux/devfreq.h | 7 +++++++
> > 2 files changed, 48 insertions(+), 6 deletions(-)
>
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>

Looks goot do me as well.

Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>


Anyway, for the sake of curiosity...

Having suspend-frequency is usually required when
the frequency configuration is reset with suspend-resume
as older Exynos's CPU did (I don't know whether it still does).

Does GPU do this as well?
(memory-bus won't do this because they are kept turned on during suspend)


Cheers,
MyungJoo