Re: [PATCH v6 02/13] arm64: add pointer authentication register bits

From: Kristina Martsenko
Date: Mon Dec 10 2018 - 14:54:41 EST


On 09/12/2018 14:24, Richard Henderson wrote:
> On 12/7/18 12:39 PM, Kristina Martsenko wrote:
>> #define SCTLR_ELx_DSSBS (1UL << 44)
>> +#define SCTLR_ELx_ENIA (1 << 31)
>
> 1U or 1UL lest you produce signed -0x80000000.

Thanks, this was setting all SCTLR bits above 31 as well... Now fixed.

> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>

Thanks for all the review!

Kristina