Re: [RESEND PATCH v2] clocksource/arm_arch_timer: fix a lockdep warning

From: Valentin Schneider
Date: Mon Dec 10 2018 - 09:20:00 EST


Hi,

On 10/12/2018 14:07, Peter Zijlstra wrote:
[...]
> ---
> kernel/cpu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 91d5c38eb7e5..e1ee8caf28b5 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -313,6 +313,8 @@ void cpus_write_unlock(void)
>
> void lockdep_assert_cpus_held(void)
> {
> + if (system_state < SYSTEM_RUNNING)
> + return;
> percpu_rwsem_assert_held(&cpu_hotplug_lock);
> }
>

Kinda hijacking the thread here - is that something we'd want to replace

40fa3780bac2 ("sched/core: Take the hotplug lock in sched_init_smp()")

with?