Re: [PATCH 6/8] Input: dt-bindings: tm2-touchkey: Document new keycodes property

From: Dmitry Torokhov
Date: Sat Dec 08 2018 - 23:57:46 EST


On Fri, Dec 07, 2018 at 11:58:09AM +0100, PaweÅ Chmiel wrote:
> From: Jonathan Bakker <xc-racer2@xxxxxxx>
>
> Document new optional property for setting custom keycodes.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@xxxxxxx>
> Signed-off-by: PaweÅ Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> ---
> .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt
> index dfb3b9f0ee40..3b54d997b8de 100644
> --- a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt
> +++ b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt
> @@ -10,6 +10,9 @@ Required properties:
> - vcc-supply : internal regulator output. 1.8V
> - vdd-supply : power supply for IC 3.3V
>
> +Optional properties:
> +- keycodes: array of keycodes (max 4), default KEY_PHONE and KEY_BACK
> +
> [0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
>
> Example:
> @@ -23,5 +26,6 @@ Example:
> interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> vcc-supply=<&ldo32_reg>;
> vdd-supply=<&ldo33_reg>;
> + keycodes = /bits/ 8 <KEY_PHONE KEY_BACK>;

We definitely have key codes bigger than 255. Just keep them normal
ints please.

> };
> };
> --
> 2.17.1
>

--
Dmitry