Re: [PATCH] checkstack.pl: fix for aarch64

From: Qian Cai
Date: Fri Dec 07 2018 - 15:47:01 EST


On Fri, 2018-12-07 at 12:24 -0800, Andrew Morton wrote:
> On Fri,ÂÂ7 Dec 2018 14:58:43 -0500 Qian Cai <cai@xxxxxx> wrote:
>
> > There is actually a space after "sp," like this,
> >
> > ffff2000080813c8:ÂÂÂÂÂÂÂa9bb7bfdÂÂÂÂÂÂÂÂstpÂÂÂÂÂx29, x30, [sp, #-80]!
> >
>
> Confused.ÂÂWhy does this matter?ÂÂWhy is the patched version superior?

<Resend in plain text.>

Right now, checkstack.pl wonât be able toÂÂprint anything on aarch64, because it
wonât be able to match the stating objdump line of a function due to this
missing space. Hence, it saw every stack is zero-size.

After applied this patch, checkpatch.pl is able to match the start of a
functionâs objdump, and then be able to calculate each functionâs stack
correctly.