Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

From: Lee Jones
Date: Fri Dec 07 2018 - 14:22:45 EST


On Fri, 07 Dec 2018, Vasily Khoruzhick wrote:

> On Fri, Dec 7, 2018 at 8:40 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> > My OCD-dar is going crazy.
> >
> > Why haven't you used the same alignment as is already there?
> >
> > If it starts to run over 80-chars then bring the others back.
> >
> > Also why is there a single liner shoved in the middle of the
> > multi-line entries? Please move the singles to the top or the
> > bottom.
>
> Hi Lee,
>
> Could you please reformat it in the way that makes your OCD-dar happy?
> It would be really nice to get

I'm afraid not, for a multitude of reasons.

The most important of which surround testing.

> AC and battery support for APX8x3 merged -- it'll make Pinebook and
> Teres-I pretty well supported by mainline kernel.

That's great. A worthy cause indeed. So I'm sure you guys will want
to turn the patch around in short order so that it's applied in time
for the next merge window.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog