Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

From: Jens Axboe
Date: Thu Dec 06 2018 - 21:23:32 EST


On 12/6/18 11:18 AM, Paolo Valente wrote:
> Hi Jens,
> the first patch in this series fixes an error in the decrementing of
> the counter of the number of groups with pending I/O. This wrong
> decrement caused loss of throughput or, less likely, of control on
> I/O. The second patch is a fix of some wrong comments, which somehow
> contributed to making the above bug more difficult to find.

Are you fine with this going into 4.21? I can't quite tell what your
intent is. The first patch has a Fixes for something that went into
this series, but then patch 2 is a comment update that would not
normally be something to be applied at this stage.

--
Jens Axboe