Re: [PATCH] dp83867: fix speed 10 in sgmii mode

From: Maxim Uvarov
Date: Thu Dec 06 2018 - 13:27:38 EST


ÐÑ, 26 ÐÐÑ. 2018 Ð. Ð 02:06, Andrew Lunn <andrew@xxxxxxx>:
>
> On Thu, Oct 25, 2018 at 02:05:30PM +0300, Max Uvarov wrote:
>
> Hi Max
>
> > For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit
>
> speed.
>
> > of DP83867_10M_SGMII_CFG register has to be cleared by software.
> > That does not affect speeds 100 and 1000 so can be done on init.
>
> It would be good to add a Fixes: tag. Has this always been broken?
>

I somehow skipped this reply. I guess that was always broken. More
likely 10M is not the speed what people use nowadays. But anyway it
will be great to fix anyway.

Max.

> Thanks
> Andrew