Re: [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

From: Joerg Roedel
Date: Thu Dec 06 2018 - 10:47:13 EST


On Wed, Dec 05, 2018 at 06:20:50PM +0000, Robin Murphy wrote:
> Is there any good reason to let .add_device/.remove_device be optional
> still? Everyone's implemented them for a while now, and on a practical level
> I don't really see how else we could expect devices to be taken in and out
> of their appropriate groups correctly.

There is probably no reason anymore to keep add_device/remove_device
option. I'll check the users and remove the pointer checks if possible.


Regards,

Joerg