Re: [PATCH v2] ptp: fix an IS_ERR() vs NULL check

From: Greg Kroah-Hartman
Date: Thu Dec 06 2018 - 08:57:24 EST


On Thu, Dec 06, 2018 at 04:38:43AM -0800, Richard Cochran wrote:
> Greg,
>
> On Tue, Dec 04, 2018 at 06:10:49PM +0300, Dan Carpenter wrote:
> > On Tue, Dec 04, 2018 at 06:55:38AM -0800, Richard Cochran wrote:
> > > On Tue, Dec 04, 2018 at 10:00:33AM +0300, Dan Carpenter wrote:
> > > >
> > > > Why did you commit 3b1ad360acad ("pps: using ERR_PTR instead of NULL
> > > > while pps_register_source fails")? You're not listed as a maintainer so
> > > > I wouldn't have known to CC you.
> > >
> > > I'm confused. Where is that commit?
>
> ...
>
> > I'm on linux-next but originally it came from the char-misc-next tree.
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-next
>
> Commit 3b1ad360acad changes a return value in the PPS core, but it is
> missing the hunk for the caller in drivers/ptp/ptp_clock.c. Can that
> be amended?

Send me a patch or tell me what I need to revert and I will be glad to
do so :)

thanks,

greg k-h