Re: [PATCH] clk: Use of_node_name_eq for node name comparisons

From: Geert Uytterhoeven
Date: Wed Dec 05 2018 - 16:17:02 EST


On Wed, Dec 5, 2018 at 8:50 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> For instances using of_node_cmp, this has the side effect of now using
> case sensitive comparisons. This should not matter for any FDT based
> system which all of these are.
>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: Tero Kristo <t-kristo@xxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> ---
> drivers/clk/renesas/clk-mstp.c | 2 +-
> drivers/clk/ti/clkctrl.c | 2 +-
> drivers/clk/ti/dpll.c | 2 +-
> drivers/clk/ux500/u8500_of_clk.c | 10 +++++-----
> 4 files changed, 8 insertions(+), 8 deletions(-)

For drivers/clk/renesas/clk-mstp.c :
Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds